config policy for users when they make a cert request #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 13 commits
October 23, 2024 17:54
suprjinx
reviewed
Oct 31, 2024
suprjinx
reviewed
Oct 31, 2024
| end | ||
|
|
||
| def config_user(identity) |
There was a problem hiding this comment.
should this be in private section?
There was a problem hiding this comment.
I left it public to be able to test it.
Initially, I was going to add my test to the unit test for the enclosing method, "issue_cert()" , but it seems like that method is only tested in an integration test here: test/integration/certificates_test.rb
I was uncomfortable adding my test to an integration test, but will if you think that is a better way to handle it. (or I could add a unit test for issue_cert.)
suprjinx
approved these changes
Nov 1, 2024
|
thanks for the review @suprjinx ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#54